r188464 - [Mips][msa] Add support for half

[Daniel Sanders]

Ok, I'll do that for the remaining patch in this set and for all future patches.

> -----Original Message-----
> From: Rafael Espíndola [mailto:rafael.espindola at gmail.com]
> Sent: 15 August 2013 17:53
> To: Daniel Sanders
> Cc: Jack Carter; llvm cfe
> Subject: Re: r188464 - [Mips][msa] Add support for half
> 
> Given the nature of the commit, Jack (or someone else that knows mips)  can
> review it. He can also commit while the commit access process goes on, but
> please do the code review in the public list.
> 
> On 15 August 2013 09:40, Daniel Sanders <Daniel.Sanders at imgtec.com>
> wrote:
> > Hi,
> >
> > Jack has one more patch to review and commit on my behalf which adds six
> builtins for conversions between floating point vectors. Three of these
> builtins depend on the half-precision type added in this commit.
> > My test plan was that after this commit, nothing should break. The next
> commit would then add the builtins that depended on it along with a
> testcase for those builtins.
> > Is it preferable to do this kind of thing in a single commit?
> >
> > I'll apply for commit access in the morning.
> >
> >> -----Original Message-----
> >> From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-
> >> bounces at cs.uiuc.edu] On Behalf Of Rafael Espíndola
> >> Sent: 15 August 2013 16:24
> >> To: Jack Carter
> >> Cc: llvm cfe
> >> Subject: Re: r188464 - [Mips][msa] Add support for half
> >>
> >> testcase?
> >>
> >> Please make sure Daniel Sanders applies for commit access.
> >>
> >> On 15 August 2013 08:16, Jack Carter <jack.carter at imgtec.com> wrote:
> >> > Author: jacksprat
> >> > Date: Thu Aug 15 10:16:57 2013
> >> > New Revision: 188464
> >> >
> >> > URL: http://llvm.org/viewvc/llvm-project?rev=188464&view=rev
> >> > Log:
> >> > [Mips][msa] Add support for half
> >> >
> >> > Add support for half (a.k.a. __fp16) in builtin descriptions.
> >> > The second argument to BUILTIN() now accepts 'h' to represent half.
> >> >
> >> > Patch by Daniel Sanders
> >> >
> >> > Modified:
> >> >     cfe/trunk/include/clang/Basic/Builtins.def
> >> >     cfe/trunk/lib/AST/ASTContext.cpp
> >> >
> >> > Modified: cfe/trunk/include/clang/Basic/Builtins.def
> >> > URL: http://llvm.org/viewvc/llvm-
> >> project/cfe/trunk/include/clang/Basic/Builtins.def?rev=188464&r1=1884
> >> 63&r
> >> 2=188464&view=diff
> >> >
> >>
> ==========================================================
> >> ====================
> >> > --- cfe/trunk/include/clang/Basic/Builtins.def (original)
> >> > +++ cfe/trunk/include/clang/Basic/Builtins.def Thu Aug 15 10:16:57
> >> > +++ 2013
> >> > @@ -25,6 +25,7 @@
> >> >  //  c -> char
> >> >  //  s -> short
> >> >  //  i -> int
> >> > +//  h -> half
> >> >  //  f -> float
> >> >  //  d -> double
> >> >  //  z -> size_t
> >> >
> >> > Modified: cfe/trunk/lib/AST/ASTContext.cpp
> >> > URL: http://llvm.org/viewvc/llvm-
> >>
> project/cfe/trunk/lib/AST/ASTContext.cpp?rev=188464&r1=188463&r2=1884
> >> 64&view=diff
> >> >
> >>
> ==========================================================
> >> ====================
> >> > --- cfe/trunk/lib/AST/ASTContext.cpp (original)
> >> > +++ cfe/trunk/lib/AST/ASTContext.cpp Thu Aug 15 10:16:57 2013
> >> > @@ -7552,6 +7552,11 @@ static QualType DecodeTypeFromStr(const
> >> >             "Bad modifiers used with 'v'!");
> >> >      Type = Context.VoidTy;
> >> >      break;
> >> > +  case 'h':
> >> > +    assert(HowLong == 0 && !Signed && !Unsigned &&
> >> > +           "Bad modifiers used with 'f'!");
> >> > +    Type = Context.HalfTy;
> >> > +    break;
> >> >    case 'f':
> >> >      assert(HowLong == 0 && !Signed && !Unsigned &&
> >> >             "Bad modifiers used with 'f'!");
> >> >
> >> >
> >> > _______________________________________________
> >> > cfe-commits mailing list
> >> > cfe-commits at cs.uiuc.edu
> >> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >> _______________________________________________
> >> cfe-commits mailing list
> >> cfe-commits at cs.uiuc.edu
> >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >