[PATCH] cpp11-migrate: Add a transform that use pass-by-value in constructors

Guillaume Papin guillaume.papin at epitech.eu
Thu Aug 15 13:01:52 PDT 2013


  Update from the code review:
    - Do not make the transform a library.
    - Rewrite Sphinx documentation.
    - Adjust the risk level of the transform to RL_Reasonable.

  Short question/answer to the last mail from David Blaikie:

  > > > While constructors are an interesting case - do you intend to/is there any
  > > > reason this hasn't been generalized over arbitrary functions that involve
  > > > taking exactly one copy of a parameter & otherwise not referencing that
  > > > parameter?
  > >
  > > I agree with you, I tried to make the structure of the code and the
  > > documentation open to new additions of the same kind. Assuming the transform
  > > gets accepted I will log an issue for enhancement in JIRA.
  >
  > Not sure if this has been discussed before, but tracking bugs in
  > llvm.org/bugs is helpful for project visibility. But do with that as
  > you will.

  The C++11 Migrator uses JIRA, a public instance available at
  http://cpp11-migrate.atlassian.net (it's documented here:
  http://clang.llvm.org/extra/cpp11-migrate.html#getting-involved).

  I didn't log any improvement yet but I wrote a note in the Sphinx documentation
  of the transform explaining that we aim at more pass-by-value transform.

Hi revane, arielbernal, tareqsiraj,

http://llvm-reviews.chandlerc.com/D1342

CHANGE SINCE LAST DIFF
  http://llvm-reviews.chandlerc.com/D1342?vs=3320&id=3507#toc

Files:
  cpp11-migrate/Core/Transform.h
  cpp11-migrate/PassByValue/PassByValue.cpp
  cpp11-migrate/PassByValue/PassByValue.h
  cpp11-migrate/PassByValue/PassByValueActions.cpp
  cpp11-migrate/PassByValue/PassByValueActions.h
  cpp11-migrate/PassByValue/PassByValueMatchers.cpp
  cpp11-migrate/PassByValue/PassByValueMatchers.h
  cpp11-migrate/tool/CMakeLists.txt
  cpp11-migrate/tool/Cpp11Migrate.cpp
  cpp11-migrate/tool/Makefile
  docs/MigratorUsage.rst
  docs/PassByValueTransform.rst
  docs/cpp11-migrate.rst
  test/cpp11-migrate/PassByValue/basic.cpp
  test/cpp11-migrate/PassByValue/basic.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D1342.2.patch
Type: text/x-patch
Size: 30751 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130815/a48fca07/attachment.bin>


More information about the cfe-commits mailing list