XCore target: Add target specific EmitVAArg

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Aug 15 08:35:24 PDT 2013


+    llvm_unreachable("Unsupported ABI kind for va_arg");

Unsupported or it is impossible to get here? If it is something a user
can hit, this should probably be report_fatal_error as
llvm_unreachable will not cause clang to stop in a -Asserts build.

+// RUN: %clang -target xcore -O3

Why run the tests at -O3? We normally prefer to test clang at -O0.

LGTM with those comments addressed.


On 15 August 2013 06:52, Robert Lytton <robert at xmos.com> wrote:
> Hi,
>
> Add target specific EmitVAArg to XCore target.
> This was so aggregates could be passed as var args too.
>
> Robert
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>



More information about the cfe-commits mailing list