[libc++] Patch for AIX port
Xing Xue
xingxue at ca.ibm.com
Wed Aug 14 11:38:46 PDT 2013
Thanks every body!
Thanks,
Xing Xue
XLC++ Compiler Development / IBM Software Solutions Toronto Lab.
Tie Line: 313-3972 Phone: 905-413-3972 Email: xingxue at ca.ibm.com
|------------>
| From: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|Michael Wong/Toronto/IBM |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| To: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|Howard Hinnant <hhinnant at apple.com> |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Cc: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|aep at exys.org, "Andrew C. Morrow" <andrew.c.morrow at gmail.com>, "cfe-commits at cs.uiuc.edu cfe" <cfe-commits at cs.uiuc.edu>, "compnerd at compnerd.org |
|Abdulrasool" <compnerd at compnerd.org>, Dimitry Andric <dimitry at andric.com>, joerg at NetBSD.org, "jyasskin at google.com Yasskin" <jyasskin at google.com>, |
|David Chisnall <theraven at FreeBSD.org>, Xing Xue/Toronto/IBM at IBMCA |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Date: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|08/14/2013 02:33 PM |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Subject: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|Re: [libc++] Patch for AIX port |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
Thank you all. This is IBM's first of many drops.
_________________________________________________________
Regards, Michael
http://isocpp.org/wiki/faq/wg21:michael-wong
OpenMP CEO: http://openmp.org/wp/about-openmp/
My Blogs: http://ibm.co/pCvPHR
C++11 status: http://tinyurl.com/43y8xgf
Boost test results
http://www.ibm.com/support/docview.wss?rs=2239&context=SSJT9L&uid=swg27006911
C/C++ Compilers Feature Request Page
http://www.ibm.com/developerworks/rfe/?PROD_ID=700
TM: https://sites.google.com/site/tmforcplusplus/
IBM Corporation
XL C++ Compiler kernel Development
IBM Canada Ltd., C2/KD2/8200/MKM
8200 Warden Avenue
Markham, Ontario L6G 1C7
W:905-413-3283 F:905-413-4839
|------------>
| From: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|Howard Hinnant <hhinnant at apple.com> |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| To: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|Xing Xue/Toronto/IBM at IBMCA |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Cc: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|aep at exys.org, "Andrew C. Morrow" <andrew.c.morrow at gmail.com>, "cfe-commits at cs.uiuc.edu cfe" <cfe-commits at cs.uiuc.edu>, "compnerd at compnerd.org |
|Abdulrasool" <compnerd at compnerd.org>, Dimitry Andric <dimitry at andric.com>, joerg at NetBSD.org, "jyasskin at google.com Yasskin" <jyasskin at google.com>, |
|Michael Wong/Toronto/IBM at IBMCA, David Chisnall <theraven at FreeBSD.org> |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Date: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|08/14/2013 02:07 PM |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Subject: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|Re: [libc++] Patch for AIX port |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
Thanks! Committed revision 188396.
Howard
On Aug 14, 2013, at 1:04 PM, Xing Xue <xingxue at ca.ibm.com> wrote:
> Hi Howard,
>
> Sure. I've revised as follows.
>
> Diffs:
> (See attached file: buildit.diffs)
>
> The actual file:
> (See attached file: buildit)
>
> However, the code in question does not seem to work to me. Notice libc+
+.so.1.0 is generated because of "-o libc++.so.1.0" in line 103. The 'ln
-s libc++.so.1 libc++.so' command in line 141 will fail. That's why line
141 was changed to 'ln -s libc++.so.1.0" in the previous patch. I think
the proper fix will be to change line 103 to "-o libc++.so.1" to be
consistent with the soname.
>
> ...
> 100 *)
> 101 RC_CFLAGS="-fPIC"
> 102 SOEXT=so
> 103 LDSHARED_FLAGS="-o libc++.so.1.0 \
> 104 -shared -nodefaultlibs -Wl,-soname,libc++.so.1 \
> 105 -lpthread -lrt -lc -lstdc++"
> 106 ;;
> ....
> 139 *)
> 140 rm -f libc++.so
> 141 ln -s libc++.so.1 libc++.so
> 142 ;;
>
> Thanks,
> Xing Xue
> XLC++ Compiler Development / IBM Software Solutions Toronto Lab.
> Tie Line: 313-3972 Phone: 905-413-3972 Email: xingxue at ca.ibm.com
>
>
>
> <graycol.gif>Howard Hinnant ---08/14/2013 10:00:34 AM---On Aug 14, 2013,
at 3:45 AM, David Chisnall <theraven at FreeBSD.org> wrote: >> rm -f
libc++.so
>
> <ecblank.gif>
> From:
> <ecblank.gif>
> Howard Hinnant <hhinnant at apple.com>
> <ecblank.gif>
> To:
> <ecblank.gif>
> Xing Xue/Toronto/IBM at IBMCA
> <ecblank.gif>
> Cc:
> <ecblank.gif>
> "cfe-commits at cs.uiuc.edu cfe" <cfe-commits at cs.uiuc.edu>, David Chisnall
<theraven at FreeBSD.org>, Michael Wong/Toronto/IBM at IBMCA,
"compnerd at compnerd.org Abdulrasool" <compnerd at compnerd.org>, Dimitry Andric
<dimitry at andric.com>, "Andrew C. Morrow" <andrew.c.morrow at gmail.com>,
aep at exys.org, joerg at NetBSD.org, "jyasskin at google.com Yasskin"
<jyasskin at google.com>
> <ecblank.gif>
> Date:
> <ecblank.gif>
> 08/14/2013 10:00 AM
> <ecblank.gif>
> Subject:
> <ecblank.gif>
> Re: [libc++] Patch for AIX port
>
>
>
>
> On Aug 14, 2013, at 3:45 AM, David Chisnall <theraven at FreeBSD.org> wrote:
>
> >> rm -f libc++.so
> >> - ln -s libc++.so.1 libc++.so
> >> + ln -s libc++.so.1.0 libc++.so
> >> ;;
> >> esac
> >>
> >> All, please examine the last line:
> >>
> >> - ln -s libc++.so.1 libc++.so
> >> + ln -s libc++.so.1.0 libc++.so
> >
> > This does, however. We don't usually use a.b version numbers. It
isn't of vital importance, however, as we don't use the upstream build
system for the libc++ that we ship, although it would be mildly
inconvenient for people who are building a newer version for testing.
> >
> > Oh, and ln -sf is generally better than rm then ln, as it allows the
operation to be atomic.
>
> Xing, can you rework this part so that it is -ibm-only?
>
> Howard
>
>
>
> <buildit.diffs><buildit>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130814/e130e99f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: graycol.gif
Type: image/gif
Size: 105 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130814/e130e99f/attachment.gif>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ecblank.gif
Type: image/gif
Size: 45 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130814/e130e99f/attachment-0001.gif>
More information about the cfe-commits
mailing list