[PATCH] cpp11-migrate: Fixing doxygen warnings

Tareq A. Siraj tareq.a.siraj at intel.com
Wed Aug 14 10:18:38 PDT 2013


Hi revane,

For some reason doxygen doesn't seem to like the using namespace
clang::tooling in the source file and complaints about missing class
members.

Also fixed missing parameter documentation for TransformName in
SourceOverrides::applyReplacements().

http://llvm-reviews.chandlerc.com/D1400

Files:
  cpp11-migrate/Core/FileOverrides.cpp
  cpp11-migrate/Core/FileOverrides.h

Index: cpp11-migrate/Core/FileOverrides.cpp
===================================================================
--- cpp11-migrate/Core/FileOverrides.cpp
+++ cpp11-migrate/Core/FileOverrides.cpp
@@ -40,7 +40,7 @@
                                  bool TrackChanges)
     : MainFileName(MainFileName), TrackChanges(TrackChanges) {}
 
-void SourceOverrides::applyReplacements(tooling::Replacements &Replaces,
+void SourceOverrides::applyReplacements(clang::tooling::Replacements &Replaces,
                                         llvm::StringRef TransformName) {
   llvm::IntrusiveRefCntPtr<clang::DiagnosticOptions> DiagOpts(
       new DiagnosticOptions());
@@ -52,8 +52,8 @@
   applyReplacements(Replaces, SM, TransformName);
 }
 
-void SourceOverrides::applyReplacements(tooling::Replacements &Replaces,
-                                        SourceManager &SM,
+void SourceOverrides::applyReplacements(clang::tooling::Replacements &Replaces,
+                                        clang::SourceManager &SM,
                                         llvm::StringRef TransformName) {
   applyOverrides(SM);
 
Index: cpp11-migrate/Core/FileOverrides.h
===================================================================
--- cpp11-migrate/Core/FileOverrides.h
+++ cpp11-migrate/Core/FileOverrides.h
@@ -141,6 +141,7 @@
   ///
   /// \param Replaces The replacements to apply.
   /// \param SM A user provided SourceManager to be used when applying rewrites.
+  /// \param TransformName The name of the transform the replacements come from.
   void applyReplacements(clang::tooling::Replacements &Replaces,
                          clang::SourceManager &SM,
                          llvm::StringRef TransformName);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D1400.1.patch
Type: text/x-patch
Size: 1718 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130814/4e5d74ae/attachment.bin>


More information about the cfe-commits mailing list