[PATCH] clang-cl: Choose executable name base on input name or /Fe

Hans Wennborg hans at chromium.org
Mon Aug 12 14:59:34 PDT 2013



================
Comment at: lib/Driver/Driver.cpp:383
@@ -371,3 +382,3 @@
     StringRef V = A->getValue();
     if (V == "") {
       // It has to have a value.
----------------
Reid Kleckner wrote:
> Silly drive by thing: this could just be V.empty()
Done.

================
Comment at: lib/Driver/Driver.cpp:380
@@ -359,2 +379,3 @@
 
   if (Arg *A = C->getArgs().getLastArg(options::OPT__SLASH_Fo)) {
+    DiagnoseOptionOverride(*this, C->getArgs(), options::OPT__SLASH_Fo);
----------------
Reid Kleckner wrote:
> Stepping back, I don't think this diagnostic-only code belongs here.  It could be sunk into BuildActions or a helper or something.
I'll look into moving it in a follow-up.


http://llvm-reviews.chandlerc.com/D1344

COMMIT
  http://llvm-reviews.chandlerc.com/rL188210



More information about the cfe-commits mailing list