[PATCH] cpp11-migrate: Write header replacements to disk

Tareq A. Siraj tareq.a.siraj at intel.com
Mon Aug 12 14:17:52 PDT 2013


  Since this revision is closed, I'll upload a new patch.


================
Comment at: clang-tools-extra/trunk/cpp11-migrate/Core/ReplacementsYaml.h:27
@@ +26,3 @@
+  std::string TransformID;
+  std::vector<clang::tooling::Replacement> GeneratedReplacements;
+};
----------------
Edwin Vane wrote:
> GeneratedReplacements -> Replacements
Done.

================
Comment at: clang-tools-extra/trunk/cpp11-migrate/Core/ReplacementsYaml.h:33
@@ +32,3 @@
+struct TransformDocument {
+  std::string FileName;
+  std::vector<TransformReplacements> Replacements;
----------------
Edwin Vane wrote:
> Filename -> HeaderFileName
Done.

================
Comment at: clang-tools-extra/trunk/cpp11-migrate/Core/ReplacementsYaml.h:32
@@ +31,3 @@
+/// the TransformReplacements.
+struct TransformDocument {
+  std::string FileName;
----------------
Edwin Vane wrote:
> TransformDocument -> HeaderChangeDocument. Also, since the plan is to only apply changes to headers one transform at a time, we no longer need a vector of TransformReplacements. Can just fold TransformReplacements into HeaderChangeDocument.
> 
> Also, can we add another field here to provide the name of the source file from which this change description was generated?
Done.


http://llvm-reviews.chandlerc.com/D1142

COMMIT
  http://llvm-reviews.chandlerc.com/rL187204



More information about the cfe-commits mailing list