[PATCH] clang-cl: Use MS C++ ABI

Reid Kleckner rnk at google.com
Thu Aug 8 12:00:41 PDT 2013


  LGTM


================
Comment at: test/Driver/cl-abi.c:1
@@ +1,2 @@
+// Don't attempt slash switches on msys bash.
+// REQUIRES: shell-preserves-root
----------------
Let's try to have fewer test files.  I've read on the lists that more files basically makes lit slower.

================
Comment at: lib/Driver/Tools.cpp:3728
@@ +3727,3 @@
+
+  CmdArgs.push_back("-cxx-abi");
+  CmdArgs.push_back("microsoft");
----------------
This should have a FIXME: Make this the default for the win32 triple.

Right now i686-pc-win32 + -cxx-abi itanium is a weird mismash of the C calling conventions plus the Itanium C++ runtime stuff that we should really eliminate.


http://llvm-reviews.chandlerc.com/D1329



More information about the cfe-commits mailing list