[patch] Correctly align arrays of int64_t on 32 bit systems

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Aug 8 05:10:29 PDT 2013


On 8 August 2013 01:36, Richard Smith <richard at metafoo.co.uk> wrote:
> Typos 'conpute', 'allignof', and 'comput' in the comment.

Fixed.

> I'm not really a big fan of ASTContext knowing about the semantics of the
> GNU alignof extension like this, but the change looks correct. Changing the
> comment to talk about semantic alignment versus ABI alignment would help
> (but that doesn't cover the following-references / not-following-references
> half).

AST suffers from being the place we have for sharing code between Sema
and Codegen. As you point out, "semantic" would be a bit vague as what
we compute is specific to alignof.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: application/octet-stream
Size: 3637 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130808/0e09f87f/attachment.obj>


More information about the cfe-commits mailing list