[PATCH] Indicate success for simple options when clang called with -cc1

[David Wiberg]

2013/8/3 Rafael Espíndola <rafael.espindola at gmail.com>:
> On 3 August 2013 04:22, David Wiberg <dwiberg at gmail.com> wrote:
>> Hello,
>>
>> Running the following line:
>>     clang -cc1 [-help | -version | -analyzer-checker-help]
>> will cause clang to exit with return code != 0.
>>
>> The attached patch changes this behavior to return 0. No test case has
>> been created. If this is wanted I will need input on where it should
>> be created.
>
> test/Frontend probably
>

Test created and new patch attached. I'm a bit uncertain about testing
the "-analyzer-checker-help" option since that is within #ifdef
CLANG_ENABLE_STATIC_ANALYZER in the code. Will this flag always be
active when running the tests? If not how should I check this in the
test?

>> Using Visual Studio I have run the "clang-test" project. Is there
>> anything else I'm supposed to do in preparation when sending a patch?
>
> No, that is it: Including the test and making sure it passes.
>
> Cheers,
> Rafael

Perhaps I should mention that I don't have commit access so I will
need help with that part later.
/ David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ReturnCode_2.patch
Type: application/octet-stream
Size: 1467 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130803/7db3b04a/attachment.obj>