[PATCH] [clang-extra-tools] [clang-format] Unicode characters escaped in FormatTest.cpp

Daniel Jasper djasper at google.com
Fri Aug 2 14:35:58 PDT 2013

Two thoughts:
a) I think it might be "better" (in some regards) to entirely disable these
tests on MSVC. Changing them to use escape sequences makes them somewhat
harder to maintain. As we run these tests frequently on other platforms the
chances of regressions are slim.
b) We want to split up the tests and have a significant portion of them in
FileCheck(-like) tests in the near future. Thus, the formatting input-data
will be in plain files that aren't compiled and this problem should go
away, making the argument for (a) stronger.

On Fri, Aug 2, 2013 at 11:02 AM, Curdeius Curdeius <curdeius at gmail.com>wrote:

> Hi,
> I've prepared a patch for clang-format unit test.
> There were encoding problems with Unicode characters on MSVC.
> I've escaped them.
> However, the 4-byte characteres don't work as expected, so the
> corresponding test is still turned off on MSVC (I've tried using escape
> sequences like "\U0001abcd" but that doesn't work neither).
> The patch is attached.
> The formatting do not stick to the coding style rules, but I didn't know
> how to handle escape sequences (yes, I could have used clang-format...).
> Cheers,
> Marek Kurdej
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130802/59791913/attachment.html>

More information about the cfe-commits mailing list