r187619 - Use llvm::sys::fs::UniqueID for windows and unix.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Fri Aug 2 05:11:02 PDT 2013

On 2 August 2013 05:12, Alexey Samsonov <samsonov at google.com> wrote:
> Hi Rafael,
> MSan reported an error after this commit, which I hopefully fixed in
> r187647.
> Default PPRegion ctor didn't initialize UniqueID, which could lead to weird
> comparison results.
> Another possible fix would be to make default UniqueID ctor initialize the
> members with zeroes, but I didn't like it,
> as UniqueID is essentially a pair, and zeroes might be valid values on some
> platforms. Could you check if this looks fine to you?

It is probably OK, Thanks!

Which test was failing?


More information about the cfe-commits mailing list