[PATCH] clang-cl: add more options

Reid Kleckner rnk at google.com
Thu Aug 1 16:18:36 PDT 2013


  LGTM

  You have far more thorough tests than I did.  =D

  The big ones that we will need to implement with custom support are:

  /M(D|Dd|T|Td): Set defines and pick the CRT
  /Fo: Picks an output file or directory
  /showIncludes: used in some build systems for header deps.  This will require actual -cc1 support.


================
Comment at: include/clang/Driver/CLCompatOptions.td:110
@@ +109,3 @@
+def _SLASH_MTd : CLFlag<"MTd">;
+def _SLASH_Ob : CLFlag<"Ob">;
+def _SLASH_Oi : CLFlag<"Oi">;
----------------
We should alias /Ob0 to -fno-inline.  We can ignore /ObN for N != 0

================
Comment at: include/clang/Driver/CLCompatOptions.td:88
@@ +87,3 @@
+def _SLASH_Zc_forScope : CLIgnoredFlag<"Zc:forScope">;
+def _SLASH_Zcwchar_t : CLIgnoredFlag<"Zc:wchar_t">;
+
----------------
Not _SLASH_Zc_wchar_t?

================
Comment at: include/clang/Driver/CLCompatOptions.td:120
@@ +119,2 @@
+def _SLASH_ZI : CLFlag<"ZI">;
+def _SLASH_Zi : CLFlag<"Zi">;
----------------
I suppose you could toss /showIncludes on here, since we'll need that.


http://llvm-reviews.chandlerc.com/D1264



More information about the cfe-commits mailing list