[PATCH] Abstract out virtual calls and virtual function prologue code generation

Timur Iskhodzhanov timurrrr at google.com
Thu Aug 1 07:50:59 PDT 2013


Hi rjmccall, rnk,

Hi Reid, John,

Can you please review this patch?

I have one style question: how do we wrap long assignments?
i.e.

  a =
    longvalue;

or

  a
    = longvalue;

?

Should I fix the style in the lines I touch anyways?

http://llvm-reviews.chandlerc.com/D1260

Files:
  include/clang/AST/VTableBuilder.h
  lib/AST/VTableBuilder.cpp
  lib/CodeGen/CGCXX.cpp
  lib/CodeGen/CGCXXABI.cpp
  lib/CodeGen/CGCXXABI.h
  lib/CodeGen/CGCall.cpp
  lib/CodeGen/CGClass.cpp
  lib/CodeGen/CGExprCXX.cpp
  lib/CodeGen/CGVTables.h
  lib/CodeGen/CodeGenFunction.h
  lib/CodeGen/CodeGenModule.h
  lib/CodeGen/ItaniumCXXABI.cpp
  lib/CodeGen/MicrosoftCXXABI.cpp
  test/CodeGenCXX/microsoft-abi-multiple-nonvirtual-inheritance.cpp
  test/CodeGenCXX/microsoft-abi-virtual-inheritance.cpp
  test/CodeGenCXX/microsoft-abi-vtables-single-inheritance.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D1260.1.patch
Type: text/x-patch
Size: 35563 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130801/39532df3/attachment.bin>


More information about the cfe-commits mailing list