[PATCH] clang-cl: Add the /c, /W0 and /W1 options
ruiu at google.com
Wed Jul 31 21:25:17 PDT 2013
I thought about case-insensitive option handling, and seems we have to
change OptTable to add a new field to indicate whether the option is case
sensitive or not. But this trend to add more fields to OptTable::Info is a
bit worriesome, so I'd like to get you guys' opinion about that.
Adding a new field to the struct is easy. What's I hesitate to do is to
modify every file that includes the tablegen-generated file. Is that
unavoidable? Omitted fields are guaranteed to be initialized by 0 in C++.
If we use this default value, we may not have to modify the files. We have
to silence -Wmissing-field-initializers in some way, though. What do you
On Wed, Jul 31, 2013 at 1:24 PM, Reid Kleckner <rnk at google.com> wrote:
> Hm, no. It looks like cl.exe is case sensitive, but link.exe is not. I
> think we can handle case sensitivity as a property of the OptTable. I'm
> not sure if we'll have to change the table generator to support this.
> On Wed, Jul 31, 2013 at 12:58 PM, Rui Ueyama <ruiu at google.com> wrote:
>> This is not a comment for this specific patch, but I'm wondering if the
>> driver can handle options in a case-insensitive manner. Does it?
>> On Wed, Jul 31, 2013 at 11:30 AM, Reid Kleckner <rnk at google.com> wrote:
>>> I would go ahead and commit, since this doesn't have any review-worthy
>>> bits now that these are just aliases. If someone objects to "CoreOption"
>>> they can bikeshed it after the commit.
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits