Unify unix and windows versions of FileManager::UniqueDirContainer and FileManager::UniqueFileContainer
silvas at purdue.edu
Wed Jul 31 13:41:25 PDT 2013
On Wed, Jul 31, 2013 at 12:27 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:
> On 31 July 2013 14:57, Sean Silva <silvas at purdue.edu> wrote:
> > - ::Emit32(Out, (uint32_t) StatBuf->st_ino);
> > - ::Emit32(Out, (uint32_t) StatBuf->st_dev);
> > - ::Emit16(Out, (uint16_t) StatBuf->st_mode);
> > - ::Emit64(Out, (uint64_t) StatBuf->st_mtime);
> > - ::Emit64(Out, (uint64_t) StatBuf->st_size);
> > - delete StatBuf;
> > + ::Emit64(Out, Data->UniqueID.getFile());
> > + ::Emit64(Out, Data->UniqueID.getDevice());
> > + ::Emit64(Out, Data->ModTime);
> > + ::Emit64(Out, Data->Size);
> > + delete Data;
> > This seems like it changes the PTH file format. Is there some format
> > number you need to bump somewhere? Or is this a "private" format?
> I was assuming it was private. I.E., the reader must be the same as
> the writer. Is that not the case?
idk; I just wanted to highlight a potential issue.
-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits