[PATCH] -include option and -exclude ignore arguments finishing with '/'

Ariel Bernal ariel.j.bernal at intel.com
Tue Jul 30 06:41:46 PDT 2013

  isFileIncluded uses a path to a file and the include/exclude list of paths. I think pre-processing the include/exclude paths once when parsed is better. And I thought that paths to files come from SourceLocations so they must be absolute paths but maybe we could call RemoveRelativePath each time isFileIncluded is called to make sure those paths don't have any relative operator.

Comment at: unittests/cpp11-migrate/IncludeExcludeTest.cpp:66
@@ +65,3 @@
+  EXPECT_TRUE(IEManager.isFileIncluded("c/c2/c3/f.cpp"));
Edwin Vane wrote:
> Could we have some tests that have '.' in the path? I'd at least like to see a path like `/path/to/dir/.` work.
yes sure.


More information about the cfe-commits mailing list