[PATCH] PR15614 : -frewrite-includes causes -Wunused-macros false positives

Eli Friedman eli.friedman at gmail.com
Mon Jul 29 18:35:39 PDT 2013


On Sun, Jul 28, 2013 at 2:50 AM, Lubos Lunak <l.lunak at suse.cz> wrote:
> On Monday 01 of July 2013, Eli Friedman wrote:
>> On Sun, Jun 30, 2013 at 12:01 AM, Lubos Lunak <l.lunak at suse.cz> wrote:
>> >   Hello,
>> >
>> >  could somebody please review and commit the atached patch for pr15610
>> > (it needs the patch for pr15610 applied first in order to apply cleanly).
>> > Thank you.
>> >
>> > Testcase?
>
>  Updated.

This isn't really the right approach; it suppresses the warning when
the -frewrite-includes flag is used, but not for the output of
-frewrite-includes, which is what actually matters.

See the thread "[PATCH] Correctly check for the main file in the
presence of line markers".

-Eli



More information about the cfe-commits mailing list