r187374 - PR16715: Fix assert in verifier: only mark call to 'operator new' as 'builtin' if

[Richard Smith]

Author: rsmith
Date: Mon Jul 29 15:14:16 2013
New Revision: 187374

URL: http://llvm.org/viewvc/llvm-project?rev=187374&view=rev
Log:
PR16715: Fix assert in verifier: only mark call to 'operator new' as 'builtin' if
corresponding 'operator new' was actually emitted as a function marked 'nobuiltin'.

Added:
    cfe/trunk/test/CodeGenCXX/new-alias.cpp
Modified:
    cfe/trunk/lib/CodeGen/CGExprCXX.cpp

Modified: cfe/trunk/lib/CodeGen/CGExprCXX.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprCXX.cpp?rev=187374&r1=187373&r2=187374&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGExprCXX.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGExprCXX.cpp Mon Jul 29 15:14:16 2013
@@ -1009,9 +1009,10 @@ static RValue EmitNewDeleteCall(CodeGenF
                                 const FunctionProtoType *CalleeType,
                                 const CallArgList &Args) {
   llvm::Instruction *CallOrInvoke;
+  llvm::Value *CalleeAddr = CGF.CGM.GetAddrOfFunction(Callee);
   RValue RV =
       CGF.EmitCall(CGF.CGM.getTypes().arrangeFreeFunctionCall(Args, CalleeType),
-                   CGF.CGM.GetAddrOfFunction(Callee), ReturnValueSlot(), Args,
+                   CalleeAddr, ReturnValueSlot(), Args,
                    Callee, &CallOrInvoke);
 
   /// C++1y [expr.new]p10:
@@ -1019,7 +1020,9 @@ static RValue EmitNewDeleteCall(CodeGenF
   ///   to a replaceable global allocation function.
   ///
   /// We model such elidable calls with the 'builtin' attribute.
-  if (Callee->isReplaceableGlobalAllocationFunction()) {
+  llvm::Function *Fn = dyn_cast<llvm::Function>(CalleeAddr);
+  if (Callee->isReplaceableGlobalAllocationFunction() &&
+      Fn && Fn->hasFnAttribute(llvm::Attribute::NoBuiltin)) {
     // FIXME: Add addAttribute to CallSite.
     if (llvm::CallInst *CI = dyn_cast<llvm::CallInst>(CallOrInvoke))
       CI->addAttribute(llvm::AttributeSet::FunctionIndex,

Added: cfe/trunk/test/CodeGenCXX/new-alias.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/new-alias.cpp?rev=187374&view=auto
==============================================================================
--- cfe/trunk/test/CodeGenCXX/new-alias.cpp (added)
+++ cfe/trunk/test/CodeGenCXX/new-alias.cpp Mon Jul 29 15:14:16 2013
@@ -0,0 +1,10 @@
+// RUN: %clang_cc1 -emit-llvm -triple x86_64-linux-gnu -std=c++11 -o - %s | FileCheck %s
+
+using size_t = decltype(sizeof(0));
+
+// CHECK: @_Znwm = alias i8* (i64)* @something
+void *operator new(size_t) __attribute__((alias("something")));
+
+// PR16715: don't assert here.
+// CHECK: call noalias i8* @_Znwm(i64 4){{$}}
+int *pr16715 = new int;