[Patch] lit.cfg: better check for MSYS

[Reid Kleckner]

On Mon, Jul 29, 2013 at 11:33 AM, Hans Wennborg <hans at chromium.org> wrote:

> On Mon, Jul 29, 2013 at 11:01 AM, NAKAMURA Takumi <geek4civic at gmail.com>
> wrote:
> > I suppose that system's python should be /usr/bin/python in Cygwin's
> world.
> > I didn't know Python/win32 could run Lit for cygwin tests.
> >
> > What is a motivation for you to take *external* python on cygwin?
>
> I build Clang outside Cygwin, in cmd.exe, because I want to build in a
> "pure win32" environment. But I fail at running the tests in cmd.exe,
> so I use Cygwin to run the tests.
>
> If I try to use Cygwin's /usr/bin/python to run the tests, it fails
> because of some Windows path. Probably because I didn't build in
> Cygwin.
>
> I guess my configuration is confusing to lit.cfg, because I have
> platform.system() = "Windows" and lit.getBashPath() =
> "C:\src\cygwin\bin\bash.EXE". But it's still not MSYS :)


This configuration is pretty handy because it's way faster to spawn
processes from native win32 python than from cygwin bash or cygwin python.

I think the odd duck that we should be checking for here is MSys, so using
the MSYSTEM env var sounds good to me.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130729/77381f14/attachment.html>