[Patch] lit.cfg: better check for MSYS

NAKAMURA Takumi geek4civic at gmail.com
Mon Jul 29 10:34:32 PDT 2013

Hans, I am certain it would be less useful on cygwin.

Python 2.6.8 (unknown, Jun  9 2012, 11:30:32)
>>> import platform
>>> platform.system()

I can see "shell-preserves-root" is enabled on cygwin.

PASS: Clang :: Driver/cl.c (2638 of 6275)

Which version of python are you using on cygwin?

2013/7/30 Hans Wennborg <hans at chromium.org>:
> Hi,
> The attached patch tightens the "shell-preserves-root" feature check
> in lit.cfg. Previously, the check would exclude this feature also on
> Cygwin, but as the comment suggests, I think it should only check for
> With this patch, the number of unsupported tests on Cygwin go from 35 to 32.
> I was not able to test this on MSYS. Takumi, could you give it a try?
> Thanks,
> Hans

More information about the cfe-commits mailing list