[clang-tools-extra] r187277 - Fixed case change that caused the test failure. Incorporarated Sean's review changes, consisting only of renaming and comment changes.

Sean Silva silvas at purdue.edu
Fri Jul 26 18:31:53 PDT 2013


Awesome documentation!

+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+// The Basic Idea
+//

Please end the license block with "//===------------------------
--------------------------------------------===//", like you did here:

+//===- PreprocessorTracker.h - Tracks preprocessor activities -*- C++
-*-===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===------------------------------------------------------
--------------===//


+// “defined” expression, or condition expression has in the course of
+// processing for the one location in the one header containing it,
+// plus a list of the nested include stacks for the states.  When a macro
+// or “defined” expression evaluates to the same value, which is the

It looks like some "smart" quotes managed to get in here. We try to keep
everything ASCII in the source code, so please try to change these to
regular ascii quotes (0x22).

+// A HeaderInclusionPath class abstract a unique hierarchy of header file

abstracts (plural)

+// MacroExpansionInstance object stores a vector of these handle so that

handles (plural)

-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130726/ff9e17ff/attachment.html>


More information about the cfe-commits mailing list