[libclang] fix PR 15074 - clang_getDeclObjCTypeEncoding returns wrong string "?" for TypeDecl cursor

David Blaikie dblaikie at gmail.com
Wed Jul 24 11:10:21 PDT 2013

If you're planning to add a test anyway - it's probably best to just
keep this patch locally until it has the test to go with it.

It's not just about the correctness of the test - but having tests
with changes (ideally in the same commit) makes a lot of historical
investigation easier.

(others may disagree with me, though - my opinion is by no means authoritative)

On Wed, Jul 24, 2013 at 11:07 AM, Jean-Luc Jumpertz
<jean-luc at zenocloud.eu> wrote:
> I had a look at the tests associated with libclang and they seem to be all contained in clang/tools/c-index-test/c-index-test.c.
> Unfortunately c-index-test.c has no test related to Objc Type encoding.
> I will eventually add one new test in the future but this will probably not be in the next days.
> Can you anyway commit the proposed fix which is IMHO really safe?
> Le 24 juil. 2013 à 18:32, David Blaikie <dblaikie at gmail.com> a écrit :
>> I haven't looked at what test coverage we have for libclang - but
>> could you see if you could add a test case if we do have some already?
>> On Wed, Jul 24, 2013 at 2:57 AM, Jean-Luc Jumpertz
>> <jean-luc at zenocloud.eu> wrote:
>>> This patch is a fix for http://llvm.org/bugs/show_bug.cgi?id=15074
>>> It is a simple matter of adding a missing "else".
>>> Note: this patch has been generated with git as explained in http://llvm.org/docs/GettingStarted.html#sending-patches-with-git. Hope there won't be any trouble for integrating it. :)
>>> Thanks,
>>> Jean-Luc
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

More information about the cfe-commits mailing list