r186947 - Fixing the build bots from the previous commit.

Aaron Ballman aaron at aaronballman.com
Tue Jul 23 08:58:15 PDT 2013


The original had no attribute name either (my adding it when creating
the tests was bogus), but I do agree that the attribute name is
beneficial.  I will add it in a subsequent commit later today (it
affects many more diagnostics than just these three).

~Aaron

On Tue, Jul 23, 2013 at 11:51 AM, jahanian <fjahanian at apple.com> wrote:
> Can you restore attribute name in the diagnostic? They are usually wrapped
> in some MACRO name.
> missing the attribute name in the diagnostic is a setback to clarity.
>
> - Fariborz
>
> On Jul 23, 2013, at 8:21 AM, Aaron Ballman <aaron at aaronballman.com> wrote:
>
> Author: aaronballman
> Date: Tue Jul 23 10:21:34 2013
> New Revision: 186947
>
> URL: http://llvm.org/viewvc/llvm-project?rev=186947&view=rev
> Log:
> Fixing the build bots from the previous commit.
>
> Modified:
>    cfe/trunk/test/SemaObjC/arc-unavailable-for-weakref.m
>    cfe/trunk/test/SemaObjC/attr-root-class.m
>    cfe/trunk/test/SemaObjC/default-synthesize-3.m
>
> Modified: cfe/trunk/test/SemaObjC/arc-unavailable-for-weakref.m
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/arc-unavailable-for-weakref.m?rev=186947&r1=186946&r2=186947&view=diff
> ==============================================================================
> --- cfe/trunk/test/SemaObjC/arc-unavailable-for-weakref.m (original)
> +++ cfe/trunk/test/SemaObjC/arc-unavailable-for-weakref.m Tue Jul 23
> 10:21:34 2013
> @@ -87,6 +87,6 @@ __attribute__((objc_arc_weak_reference_u
> @synthesize font = _font;
> @end
>
> -__attribute__((objc_arc_weak_reference_unavailable(1))) // expected-error
> {{attribute 'objc_arc_weak_reference_unavailable' takes no arguments}}
> +__attribute__((objc_arc_weak_reference_unavailable(1))) // expected-error
> {{attribute takes no arguments}}
> @interface I3
> @end
>
> Modified: cfe/trunk/test/SemaObjC/attr-root-class.m
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/attr-root-class.m?rev=186947&r1=186946&r2=186947&view=diff
> ==============================================================================
> --- cfe/trunk/test/SemaObjC/attr-root-class.m (original)
> +++ cfe/trunk/test/SemaObjC/attr-root-class.m Tue Jul 23 10:21:34 2013
> @@ -15,6 +15,6 @@ __attribute__((objc_root_class)) static
> {
> }
>
> -__attribute__((objc_root_class(1))) // expected-error {{attribute
> 'objc_root_class' takes no arguments}}
> +__attribute__((objc_root_class(1))) // expected-error {{attribute takes no
> arguments}}
> @interface I1
> @end
>
> Modified: cfe/trunk/test/SemaObjC/default-synthesize-3.m
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/default-synthesize-3.m?rev=186947&r1=186946&r2=186947&view=diff
> ==============================================================================
> --- cfe/trunk/test/SemaObjC/default-synthesize-3.m (original)
> +++ cfe/trunk/test/SemaObjC/default-synthesize-3.m Tue Jul 23 10:21:34 2013
> @@ -154,6 +154,6 @@ __attribute ((objc_requires_property_def
> @synthesize failureCount = _failureCount;
> @end
>
> -__attribute ((objc_requires_property_definitions(1))) // expected-error
> {{attribute 'objc_requires_property_definitions' takes no arguments}}
> +__attribute ((objc_requires_property_definitions(1))) // expected-error
> {{attribute takes no arguments}}
> @interface I1
> @end
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>



More information about the cfe-commits mailing list