[PATCH] Replacing one diagnostic with another

Jordan Rose jordan_rose at apple.com
Tue Jul 23 09:02:18 PDT 2013

Mm...seems a bit weird to index the attribute parameters when there's only one. Can we special case that with a %plural?


On Jul 23, 2013, at 8:47 , Aaron Ballman <aaron at aaronballman.com> wrote:

> The err_attribute_not_string error seems like it can be subsumed by
> the err_attribute_argument_n_type diagnostic; the main difference
> between the two being that the latter specifies an argument position
> while the former does not.
> This patch performs the replacement, but I wanted to make sure it was
> acceptable.  If the consensus is that this is fine, I will commit a
> separate patch that does the same for err_attribute_argument_not_int.
> ~Aaron
-------------- next part --------------
A non-text attachment was scrubbed...
Name: attr_str.patch
Type: application/octet-stream
Size: 4728 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130723/87cc954d/attachment.obj>
-------------- next part --------------
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

More information about the cfe-commits mailing list