[PATCH] Correcting attribute argument count errors

Aaron Ballman aaron at aaronballman.com
Tue Jul 23 05:28:19 PDT 2013


Thanks, committed in r186936!

~Aaron

On Mon, Jul 22, 2013 at 5:32 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> LGTM.
>
> -Eli
>
> On Mon, Jul 22, 2013 at 12:26 PM, Aaron Ballman <aaron at aaronballman.com> wrote:
>> Ping
>>
>> ~Aaron
>>
>> On Thu, Jul 18, 2013 at 2:20 PM, Aaron Ballman <aaron at aaronballman.com> wrote:
>>> While doing some refactoring with the way attributes are diagnosed, I
>>> noticed that the NSObject and Overloadable attributes seemed to emit
>>> an incorrect diagnostic.  Specifically, both would check that no
>>> arguments were passed, but then proceed to emit a diagnostic
>>> suggesting that an argument was required.
>>>
>>> This patch corrects the behavior so that the diagnostic matches the
>>> expectation, and adds test cases for both attributes.
>>>
>>> ~Aaron
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list