[PATCH] Fix doxygen warnings

Ariel Bernal ariel.j.bernal at intel.com
Mon Jul 22 21:38:35 PDT 2013

Comment at: cpp11-migrate/Core/FileOverrides.cpp:36
@@ -36,1 +35,3 @@
+SourceOverrides::applyReplacements(clang::tooling::Replacements &Replaces) {
   llvm::IntrusiveRefCntPtr<clang::DiagnosticOptions> DiagOpts(
Edwin Vane wrote:
> Guillaume Papin wrote:
> > Ariel Bernal wrote:
> > > Edwin Vane wrote:
> > > > Ariel Bernal wrote:
> > > > > Edwin Vane wrote:
> > > > > > using namespace clang::tooling is in effect. Why not just remove tooling::? Does this fix Doxygen too?
> > > > > The problem is that the method definition in FileOverrides.h doesn't match the type and doxygen can't find this declaration.
> > > > There's got to be more to this problem than that. If you look at Transform.h and Transform.cpp you'll see the header uses clang:: in the method declaration and the source file doesn't use clang:: because of the using directive. Doxygen doesn't complain about this file...
> > > Yes you are right. I'll try to find out why it doesn't work here.
> > In the other cases Doxygen doesn't complain because they are not overloaded I think, no?
> > In this case `applyReplacements()` is overloaded and Doxygen is confused since the types aren't exactly the same (just a guess here).
> > 
> > Interesting link: http://doxygen.10944.n7.nabble.com/warning-no-uniquely-matching-class-member-found-for-doSomething-td2276.html
> > 
> > IMHO the fix is acceptable but maybe I will add the missing documentation to the `applyReplacements()` that doesn't require the SourceManager. To say it's a convenience method that creates its own SourceManager.
> If what you say is true then I guess we have to live with using clang::tooling:: even though it's not necessary in the code.
@Sarcasm I tried removing one of the overloaded methods and doxygen doesn't complain anymore. It seems that we have to keep the parameters in sync to avoid this warning.
@revane Should I commit this fix?


More information about the cfe-commits mailing list