r186889 - Don't emit open-paren fixit without close-paren.

Eli Friedman eli.friedman at gmail.com
Mon Jul 22 16:32:08 PDT 2013


On Mon, Jul 22, 2013 at 4:14 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> On Mon, Jul 22, 2013 at 4:09 PM, Eli Friedman <eli.friedman at gmail.com>
> wrote:
>>
>> Author: efriedma
>> Date: Mon Jul 22 18:09:39 2013
>> New Revision: 186889
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=186889&view=rev
>> Log:
>> Don't emit open-paren fixit without close-paren.
>>
>> getLocForEndOfToken() isn't guaranteed to succeed; if it doesn't, make
>> sure
>> we do something sane.
>>
>> Fixes PR16673.  I'm not sure how to write a testcase for this short of
>> grepping
>> through the diagnostic output.
>
>
> You can use -fdiagnostics-parseable-fixits with FileCheck to test fixits on
> notes.

Thanks; r186891.

-Eli



More information about the cfe-commits mailing list