[PATCH] cpp11-migrate: Register the transforms automatically using llvm::Registry.

Edwin Vane edwin.vane at intel.com
Mon Jul 22 13:15:51 PDT 2013


  One question, otherwise LGTM. Very nice!


================
Comment at: cpp11-migrate/AddOverride/AddOverride.cpp:75
@@ +74,2 @@
+// and thus register the factory.
+volatile int AddOverrideTransformAnchorSource = 0;
----------------
Where is this trick documented?

================
Comment at: cpp11-migrate/Core/Transform.cpp:131
@@ -130,4 +130,3 @@
 
-FrontendActionFactory *
-Transform::createActionFactory(MatchFinder &Finder) {
+FrontendActionFactory *Transform::createActionFactory(MatchFinder &Finder) {
   return new ActionFactory(Finder, /*Owner=*/ *this);
----------------
This change is unrelated to your patch. Please undo.


http://llvm-reviews.chandlerc.com/D1196



More information about the cfe-commits mailing list