[PATCH] [ms-cxxabi] Emit linkonce complete dtors in TUs that need them

Reid Kleckner rnk at google.com
Mon Jul 22 06:54:12 PDT 2013


On Fri, Jul 19, 2013 at 11:10 PM, John McCall <rjmccall at gmail.com> wrote:

> +  /// Returns true if the given destructor type should be emitted as a
> linkonce
> +  /// delegating thunk, regardless of whether the dtor is defined in this
> TU or
> +  /// not.
> +  virtual bool useThunkForDtorVariant(CXXDtorType DT) const = 0;
>
> Go ahead and make this take the destructor decl as well.
>

Sure, but it's dead.

Otherwise, this looks great, thanks!
>

Thanks for the review!  r186828
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130722/11a8345a/attachment.html>


More information about the cfe-commits mailing list