[PATCH] Fix source location info for C++03 access declarations.

Enea Zaffanella zaffanella at cs.unipr.it
Mon Jul 22 05:46:09 PDT 2013

On 07/21/2013 09:15 PM, Richard Smith wrote:
> On Sun, Jul 21, 2013 at 11:31 AM, Enea Zaffanella
> <zaffanella at cs.unipr.it <mailto:zaffanella at cs.unipr.it>> wrote:
>     On 07/12/2013 10:51 PM, Enea Zaffanella wrote:
>         On 07/12/2013 08:53 PM, Eli Friedman wrote:
>           > Please split this patch.  It's practically unreadable as-is.
>           >
>           > -Eli

Here is the third (and last) part of the patch. Actually ... this is a 
different patch wet the one proposed before.

In UnresolvedUsingTypenameDecl nodes, the UsingLocation field is not 
initialized in the constructor, nor it is ever accessed, e.g., when 
(de-)serializing the node. The start location for the source range is 
obtained by querying the TypeDecl base class. Hence, the patch simply 
removes this apparently useless source location field.

OK to commit?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: UnresolvedUsingTypenameDecl-2.patch
Type: text/x-diff
Size: 495 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130722/710b8f29/attachment.patch>

More information about the cfe-commits mailing list