[PATCH] Enhance PPCallbacks::Defined callback to provide SourceRange

[Thompson, John]

Kim,

Thanks for the heads-up.  Sounds like a good idea.  I can do it in the process.

-John

-----Original Message-----
From: Kim Gräsman [mailto:kim.grasman at gmail.com] 
Sent: Friday, July 19, 2013 2:19 PM
To: Thompson, John
Cc: Argyrios Kyrtzidis; cfe-commits at cs.uiuc.edu
Subject: Re: [PATCH] Enhance PPCallbacks::Defined callback to provide SourceRange

John, Argyrios,

On Fri, Jul 19, 2013 at 8:45 PM, Thompson, John <John_Thompson at playstation.sony.com> wrote:
>
>>It would be great if you could also add some unit tests for the recent  
>>changes in unittests/Lex/PPCallbacksTest.cpp but this can be done  
>>post-commit.
>
> Oh, I didn't know about this test.  Thanks for pointing it out. Will do.

I wrote PPCallbacksTest originally, and looking back at it, it's very centered around the InclusionDirective callback. I wonder if it should change names into PPCallbacksInclusionDirectiveTest or something?

The setup is pretty heavy for InclusionDirective, so it might prove painful to add new, simpler PPCallbacks tests to this suite.

Just a heads-up,
- Kim