[PATCH] Declare as Inheritable attributes that are already processed that way

Aaron Ballman aaron at aaronballman.com
Thu Jul 18 12:14:02 PDT 2013


I've applied (without ExtVectorType, Mode or OpenCLImageAccess
changes) in r186598.  Those other three may be covered by a different
patch I submitted earlier adding support for encoding type attributes.

~Aaron

On Thu, Jul 18, 2013 at 2:46 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Thu, Jul 18, 2013 at 11:29 AM, Dean Sutherland <dsutherland at cert.org> wrote:
>> Change declarations of 8 attributes to InheritableAttr from Attr.  All eight are already processed as inheritable attributes. This change makes their declaration match the processing. This is clean-up in preparation for tablegen improvements to reduce redundancy in SemaDeclAttr and friends. No functional changes intended.
>>
>> The effected attributes are:
>> OpenCLKernel
>> OpenCLImageAccess
>> ExtVectorType
>> Mode
>> ObjCPreciseLifetime
>> ObjCReturnsInnerPointer
>> ObjCRootClass
>> ObjCOwnership
>
> Hmm...
>
> For ExtVectorType, Mode, and OpenCLImageAccess, I'm not sure it makes
> sense to say they're inherited: processTypeAttrs in SemaType.cpp
> always handles them.
>
> The others are fine.  (You don't need to get confirmation from the
> people who wrote them.)
>
> -Eli
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list