[PATCH] Make tooling::Range more convenient.

Manuel Klimek klimek at google.com
Tue Jul 16 22:53:28 PDT 2013


  Looking at your code example, I personally like the second one better, as it's immediately obvious what the state of Range will be after the line; in the first example, all I see is that offset changes, and I need the full knowledge about the rest of Range to understand what can and cannot happen. So I stand by my decision.

  Thanks for taking the time to propose the patch though! I think it's always good to revisit some decisions and make sure they're still the right ones.

http://llvm-reviews.chandlerc.com/D1156



More information about the cfe-commits mailing list