[PATCH] Fixing a driver bug where clang cannot locate source file at drive root

Aaron Ballman aaron at aaronballman.com
Mon Jul 15 14:45:45 PDT 2013


In agree with Rafael's comments: I'm not certain this fix is in the
right place, nor comprehensive enough (perhaps).  I think we should
consider how this fits into the path namespace as well.  For instance,
path::root_name is a bit of a concern since it returns c: for c:\
(what does it return for c:test.c?)  What should path::root_path
return (should it expand?).  And so on.

As for tests, I would recommend adding unit tests to
llvm/unittests/Support/Path.cpp.

Thanks for working on this!

~Aaron

On Mon, Jul 15, 2013 at 4:56 PM, Rafael Ávila de Espíndola
<rafael.espindola at gmail.com> wrote:
>
>   Is this actually clang specific? Shouldn't the fix be in llvm so that things like
>
>   llvm-as C:test.ll
>
>   also work?
>
> http://llvm-reviews.chandlerc.com/D937
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list