r186275 - Add missing include guards into headers in lib/Headers. While it may appear

Richard Smith richard at metafoo.co.uk
Mon Jul 15 10:41:25 PDT 2013


On Sun, Jul 14, 2013 at 3:51 PM, Eli Friedman <eli.friedman at gmail.com>wrote:

> On Sat, Jul 13, 2013 at 10:41 PM, Richard Smith
> <richard-llvm at metafoo.co.uk> wrote:
> > Author: rsmith
> > Date: Sun Jul 14 00:41:45 2013
> > New Revision: 186275
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=186275&view=rev
> > Log:
> > Add missing include guards into headers in lib/Headers. While it may
> appear
> > that these headers should not be included more than once, they are in
> fact
> > included twice when building our builtins module (in order for it to
> generate
> > submodules for them), and without this, any modular build enabling AVX
> and
> > including any builtin header fails.
>
> Err, I don't think we're actually supposed to be building submodules
> for these... they can't be compiled independently anyway.


Well... this change lets us support the likes of

  @import _Builtin_intrinsics.intel.avx;

which we already supported for the other submodules here. I'm not sure
whether that was intentional, or whether this was just application of a
"one submodule per .h file" rule. Doug?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130715/a5f39836/attachment.html>


More information about the cfe-commits mailing list