[PATCH] Microsoft C++ Record Layout
chandlerc at google.com
Thu Jul 11 10:22:44 PDT 2013
On Thu, Jul 11, 2013 at 10:06 AM, Warren Hunt <whunt at google.com> wrote:
> Yes, I should have noted there are two warnings that I haven't
> implemented. It's much easier to drop them into the builder than it is to
> add them to Sema, although it makes more logical sense to put them in Sema
> (which would be a different patch). I'm okay with either, are there any
> strong votes?
I really feel like this warning is better done is Sema. Notably, the AST
should actually preserve all of the information necessary to implement this
warning, and not putting it in the (weird) place of *inside* the AST
implementation is a great way of ensuring this remains true.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits