r185873 - [Objective-C migrator] replace candidate user setter/getter with

Jordan Rose jordan_rose at apple.com
Tue Jul 9 17:33:52 PDT 2013


On Jul 9, 2013, at 17:24 , jahanian <fjahanian at apple.com> wrote:

>>> + at property(weak) NSString *__weak WeakProp;
>>> +
>>> + at property(strong) NSString * StrongProp;
>> 
>> Conventionally, I'd expect the __weak to disappear and the "strong" to be implied instead of explicitly spelled out.
> 
> __weak came from user code. migration did not generate it. removed “strong” from migrated attributes.

I see that it came from user code; it should go away during the migration.

Actually, most "weak" properties will not look like this. A weak implicit property will have a normal signature for the getter and setter, but the backing ivar will be __weak.

You really can't migrate properties without looking at the setter implementation. In that sense it's pushing more info into the interface, not less.

Jordan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130709/fe92b988/attachment.html>


More information about the cfe-commits mailing list