r185582 - [PowerPC] FreeBSD does not require f128 in its data layout string.

Bill Schmidt wschmidt at linux.vnet.ibm.com
Thu Jul 4 13:55:06 PDT 2013


On Thu, 2013-07-04 at 09:50 -0700, David Blaikie wrote:
> On Wed, Jul 3, 2013 at 2:03 PM, Bill Schmidt
> <wschmidt at linux.vnet.ibm.com> wrote:
> > Author: wschmidt
> > Date: Wed Jul  3 16:03:06 2013
> > New Revision: 185582
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=185582&view=rev
> > Log:
> > [PowerPC] FreeBSD does not require f128 in its data layout string.
> >
> > Long double is 64 bits on FreeBSD PPC, so the f128 entry is superfluous.
> 
> Not highly valuable, but seems like something pretty trivial to add a
> test case for...

I should have noted that this patch was added as a result of
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20130701/083121.html, which provides a test case that will fire if FreeBSD were to ever go to a 128-bit long double.  The existing data layout string caused me to question that patch.  I think that test case should be sufficient.

Thanks,
Bill

> 
> >
> > Modified:
> >     cfe/trunk/lib/Basic/Targets.cpp
> >
> > Modified: cfe/trunk/lib/Basic/Targets.cpp
> > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=185582&r1=185581&r2=185582&view=diff
> > ==============================================================================
> > --- cfe/trunk/lib/Basic/Targets.cpp (original)
> > +++ cfe/trunk/lib/Basic/Targets.cpp Wed Jul  3 16:03:06 2013
> > @@ -1180,7 +1180,7 @@ public:
> >        LongDoubleWidth = LongDoubleAlign = 64;
> >        LongDoubleFormat = &llvm::APFloat::IEEEdouble;
> >        DescriptionString = "E-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-"
> > -                          "i64:64:64-f32:32:32-f64:64:64-f128:64:64-"
> > +                          "i64:64:64-f32:32:32-f64:64:64-"
> >                            "v128:128:128-n32:64";
> >      } else
> >        DescriptionString = "E-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-"
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 




More information about the cfe-commits mailing list