[PATCH] [libc++] Use snprintf() instead of sprintf()

Howard Hinnant hhinnant at apple.com
Tue Jul 2 11:31:21 PDT 2013


I believe we're ok here.  All of your sizeof's are of compile-time sized arrays.

Howard

On Jul 2, 2013, at 2:23 PM, Matthew Dempsky <matthew at dempsky.org> wrote:

> Hm, now I recall why I avoided using sizeof originally:
> http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2013/n3639.html
> does not define sizeof for runtime-sized arrays (though clang and gcc
> both allow that, even in strict c++ mode).
> 
> On Tue, Jul 2, 2013 at 10:44 AM, Matthew Dempsky <matthew at dempsky.org> wrote:
>> On Tue, Jul 02, 2013 at 07:30:43PM +0200, Joerg Sonnenberger wrote:
>>> On Tue, Jul 02, 2013 at 09:55:18AM -0700, Matthew Dempsky wrote:
>>>> On Sat, Jun 29, 2013 at 08:47:18PM -0400, Howard Hinnant wrote:
>>>>> I'm having trouble applying this patch:
>>>> 
>>>> Sorry, redone patch attached.  Please try again.
>>> 
>>> Please use sizeof() explicitly.
>> 
>> Done.
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list