[PATCH] Fix SimpleSValBuilder::evalBinOpLN

Jordan Rose jordan_rose at apple.com
Mon Jul 1 18:39:08 PDT 2013

On Jun 24, 2013, at 9:06 , Matthew Dempsky <matthew at dempsky.org> wrote:

> On Mon, Jun 24, 2013 at 9:03 AM, Jordan Rose <jordan_rose at apple.com> wrote:
> There aren't any...all of the symmetrical operations require both arguments to be of the same type. I'm pretty sure the "Special case" below for the compare-and-swap functions is now dead code.
> That sounds plausible to me.
> Do you think it'd worth adding an assertion that we never get a comparison op here?
> Yep, removing the isComparisonOp() code path, and adding an assert to ensure it isn't reached (before the rhs.isZeroConstant() check) sounds good to me.

Done in r185401. Thanks!

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130701/05c6e76b/attachment.html>

More information about the cfe-commits mailing list