[PATCH] Make RecursiveASTVisitor::TraverseLambdaExpr call WalkUpFromLambdaExpr

Richard Smith richard at metafoo.co.uk
Fri Jun 28 15:34:22 PDT 2013

LGTM, please also apply the same fix to tools/libclang/RecursiveASTVisitor.h.

On Fri, Jun 28, 2013 at 1:10 AM, James Dennett <jdennett at google.com> wrote:
> I believe that there's a bug in
> RecursiveASTVisitor::TraverseLambdaExpr, in that it fails to actually
> call the Visit* functions on the LambdaExpr itself, while the
> documentation (and desired behavior) says that TraverseFoo(x) should
> call WalkUpFromFoo(x) and then recursively visit x's children.
> This patch adds in the obvious call to WalkUpFromLambdaExpr, and a
> test (that fails with the current RecursiveASTVisitor and passes with
> the fixed version).
> The test depends on a previous patch I've just sent for review ("Allow
> TestVisitor-based tests to specify use of C++11").
> Please take a look.
> -- James
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

More information about the cfe-commits mailing list