[patch] Correctly classifying PackExpansionType as NON_CANONICAL_UNLESS_DEPENDENT

David Blaikie dblaikie at gmail.com
Fri Jun 28 14:15:08 PDT 2013


Ping

On Fri, Jun 21, 2013 at 1:45 PM, David Blaikie <dblaikie at gmail.com> wrote:
> Hi Richard,
>
> From our conversation/your help this morning, here's a patch that at
> least solves my original problem (Type::getAs<TagDecl> on a RecordDecl
> of a non-dependent alias template).
>
> Does this look about right? This doesn't address the further
> simplification of getTypeInfoImpl that we were discussing, but I
> expect that can be handled before/after (happy to do it, though, if
> you would like me to have a go at it). Are there some test cases I
> should add? (I don't know the code well enough to know if this
> manifests in any real way, I assume it does though)
>
> Thanks,
> - David



More information about the cfe-commits mailing list