[PATCH] Emulate MSVC handling of commas during macro arg expansion

Will Wilson will at indefiant.com
Fri Jun 28 05:11:07 PDT 2013


Thanks of the commit! Sorry for the incorrect flag value - it was a rush
job before I had to leave for a wedding. My excuse at least :)

On Wednesday, June 26, 2013, Aaron Ballman wrote:

> On Wed, Jun 26, 2013 at 1:18 PM, Reid Kleckner <rnk at google.com<javascript:;>>
> wrote:
> > I also tried this patch on a bunch of gtest code and on an iostream hello
> > world program using VS 2012's iostream and it works for both.  Awesome!
> >
> > I can also repro the assertions Aaron hits in the Preprocessor tests.
> > They're caused by:
> > -    HasUCN = 0x40          // This identifier contains a UCN.
> > +    HasUCN = 0x40,         // This identifier contains a UCN.
> > +    IgnoredComma = 0x08,   // This comma is not a macro argument
> separator
> > (MS).
> >
> > It should be 0x80, not 0x08.
> >
> > With that change, everything passes, and I committed it as r184968.
>
> Good catch, and thanks!
>
> ~Aaron
>


-- 
*Indefiant Ltd.*
*
*
Firsby Lodge, New Main Road, Scamblesby, Louth, Lincs LN11 9XH UK
*Tel: +44 20 8123 7663 England Registered No. 07936820 VAT No. **128556202*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130628/9356d674/attachment.html>


More information about the cfe-commits mailing list