[libclc] r184999 - Add a another TODO note.

Tom Stellard thomas.stellard at amd.com
Wed Jun 26 11:21:25 PDT 2013


Author: tstellar
Date: Wed Jun 26 13:21:25 2013
New Revision: 184999

URL: http://llvm.org/viewvc/llvm-project?rev=184999&view=rev
Log:
Add a another TODO note.

Patch by: Aaron Watry

Modified:
    libclc/trunk/generic/lib/integer/rotate.inc

Modified: libclc/trunk/generic/lib/integer/rotate.inc
URL: http://llvm.org/viewvc/llvm-project/libclc/trunk/generic/lib/integer/rotate.inc?rev=184999&r1=184998&r2=184999&view=diff
==============================================================================
--- libclc/trunk/generic/lib/integer/rotate.inc (original)
+++ libclc/trunk/generic/lib/integer/rotate.inc Wed Jun 26 13:21:25 2013
@@ -27,6 +27,9 @@ _CLC_OVERLOAD _CLC_DEF GENTYPE rotate(GE
     
     UGENTYPE x_1 = __builtin_astype(x, UGENTYPE);
 
+    //XXX: Is (UGENTYPE >> SGENTYPE) | (UGENTYPE << SGENTYPE) legal?
+    //     If so, then combine the amt and shifts into a single set of statements
+    
     UGENTYPE amt;
     amt = (n < (GENTYPE)0 ? __builtin_astype((GENTYPE)0-n, UGENTYPE) : (UGENTYPE)0);
     x_1 = (x_1 >> amt) | (x_1 << ((UGENTYPE)GENSIZE - amt));





More information about the cfe-commits mailing list