[PATCH] Fix SimpleSValBuilder::evalBinOpLN

[Matthew Dempsky]

On Mon, Jun 24, 2013 at 9:03 AM, Jordan Rose <jordan_rose at apple.com> wrote:

> There aren't any...all of the symmetrical operations require both
> arguments to be of the same type. I'm pretty sure the "Special case" below
> for the compare-and-swap functions is now dead code.
>

That sounds plausible to me.

Do you think it'd worth adding an assertion that we never get a comparison
> op here?
>

Yep, removing the isComparisonOp() code path, and adding an assert to
ensure it isn't reached (before the rhs.isZeroConstant() check) sounds good
to me.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130624/3b8dc6d8/attachment.html>