[patch] Suggest no-arg calls for overloaded member functions & member function templates

David Blaikie dblaikie at gmail.com
Fri Jun 21 16:56:33 PDT 2013


On Fri, Jun 7, 2013 at 2:49 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> Only one comment: now that isExprCallable has non-trivial semantic
> effects (attempting to build an expression, instantiating templates,
> ...) it should have a scarier name that indicates it should only be
> used during error recovery.

Done, committed as r184612. Not sure the name was the best (& isn't
clear how it differs from the wrapper function, for example) -
tryExprAsCall. Open to other suggestions/comments.

>
> On Tue, Jun 4, 2013 at 1:01 PM, David Blaikie <dblaikie at gmail.com> wrote:
>> On Tue, Jun 4, 2013 at 1:00 PM, Jordan Rose <jordan_rose at apple.com> wrote:
>>> ENOPATCH
>>
>> Touché (& thanks)
>>
>> Attached.
>>
>>
>>>
>>> On Jun 4, 2013, at 12:04 , David Blaikie <dblaikie at gmail.com> wrote:
>>>
>>>> An enhancement to r183173, but I'm sending this out for review because
>>>> I expect there's a better/correct way for me to suppress diagnostics
>>>> when calling "BuildCallToMemberFunction" (or some alternative I should
>>>> use)
>>>>
>>>> Also, we could do something similar for non-member functions to get
>>>> higher accuracy there (template problems like deduction, etc apply
>>>> there too)
>>>>
>>>> - Dave
>>>> _______________________________________________
>>>> cfe-commits mailing list
>>>> cfe-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>




More information about the cfe-commits mailing list