[PATCH] [AST] Introduce a new DecayedType sugar node

Richard Smith richard at metafoo.co.uk
Fri Jun 21 14:08:30 PDT 2013


  LGTM


================
Comment at: include/clang/AST/TypeLoc.h:986
@@ +985,3 @@
+  TypeLoc getOriginalLoc() const {
+    return this->getInnerTypeLoc();
+  }
----------------
Don't need "this->" here.

================
Comment at: include/clang/AST/TypeLoc.h:996
@@ +995,3 @@
+    // location information for.
+    return this->getTypePtr()->getOriginalType();
+  }
----------------
Or here.

================
Comment at: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp:310
@@ -309,3 +309,3 @@
   // Is the argument a 'char*'?
-  const PointerType *PT = dyn_cast<PointerType>(FPT->getArgType(0));
+  const PointerType *PT = FPT->getArgType(0)->getAs<PointerType>();
   if (!PT)
----------------
There's a bunch more of these elsewhere in the file. Please commit these fixes separately.

================
Comment at: tools/libclang/RecursiveASTVisitor.h:790
@@ +789,3 @@
+DEF_TRAVERSE_TYPE(DecayedType, {
+    TRY_TO(TraverseType(T->getDecayedType()));
+    TRY_TO(TraverseType(T->getOriginalType()));
----------------
Drop this line.


http://llvm-reviews.chandlerc.com/D1014



More information about the cfe-commits mailing list