r174685 - Fix stack overflow and improve performance when a module contains many

[Chandler Carruth]

On Thu, Jun 20, 2013 at 6:15 PM, John McCall <rjmccall at apple.com> wrote:

> On Jun 20, 2013, at 12:37 AM, Chandler Carruth <chandlerc at google.com>
> wrote:
>
> On Thu, Feb 7, 2013 at 4:37 PM, Richard Smith <richard-llvm at metafoo.co.uk>wrote:
>
>> cfe/trunk/test/Modules/cxx-many-overloads.cpp
>>
>
> Hate to dig up this test, but I wanted to mention that this is the single
> slowest test in the regression test suite for me at 28.84s... Wondered if
> you had any ideas about making it cheaper.
>
>
> Maybe it would just more appropriate in a different test suite?  I believe
> there are a number of bots that run clang-tests, and getting 100% platform
> coverage doesn't seem completely imperative here.
>

My suspicion (which is nothing more as I've not investigated) is that this
is testable with a reasonable cheap test, and having in the basic 'make
check' pattern seems worthwhile on the whole. But certainly if the first
proves to not be the case, we shouldn't keep it here just for the second...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130621/6ba95d34/attachment.html>