[PATCH] [ms-cxxabi] Destroy temporary record arguments in the callee

[Reid Kleckner]

On Thu, Jun 20, 2013 at 1:37 PM, John McCall <rjmccall at apple.com> wrote:

> Good point, sorry.
>
> Hmm.  It looks like ActOnStartOfFunctionDef, ActOnStartOfObjCMethodDef,
> ActOnBlockArguments, and addLambdaParameters all have basically the same
> loop in them, but doing slightly different checks for no particular reason.
>  And there's already a CheckParmsForFunctionDef method, but it's apparently
> not called for ObjC methods.
>
> I think it makes sense to have a single method called in all of these
> cases which performs the basic checks, sets ownership, and pushes
> parameters into scope.  That method would be a natural place for your call
> to FinalizeVarWithDestructor.
>

I ended up putting it in CheckParmsForFunctionDef.  Probably ObjC methods
should be calling that?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130620/90837c8e/attachment.html>